Make KEY keyword usable as identifier in column and table names#2387
Merged
Make KEY keyword usable as identifier in column and table names#2387
Conversation
Copilot
AI
changed the title
[WIP] Limit the impact of using the keyword: KEY
Make KEY keyword usable as identifier in column and table names
Dec 16, 2025
mathiasrw
approved these changes
Dec 17, 2025
Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>
Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>
Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>
Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>
e57ffda to
bf532b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The KEY keyword was reserved in all contexts, preventing its use as column or table names. This caused parse errors for common schemas where "key" is a natural identifier (e.g., key-value stores, API keys).
Changes
Grammar modifications (
src/alasqlparser.jison):KEY Literalvariant from IndexKey rule (eliminates parser ambiguity when parsing column definitions)Test coverage (
test/test2203.js):Example
Breaking Change
Index creation via
KEY idx_name (column)no longer supported. UseINDEX idx_name (column)instead. This MySQL-specific variant was redundant with the standard INDEX keyword.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.